Re: [PATCH] staging: octeon: remove typedefs from octeon-stubs.h

From: Greg Kroah-Hartman

Date: Sun Apr 26 2026 - 23:51:15 EST


On Sun, Apr 26, 2026 at 11:11:00AM +0800, Eric Wu wrote:
> The Linux kernel coding style discourages the use of typedefs for
> enums and structs. checkpatch reports seven "do not add new typedefs"
> warnings on drivers/staging/octeon/octeon-stubs.h.
>
> Drop the typedef wrappers in octeon-stubs.h and convert the affected
> users in ethernet.c and octeon-ethernet.h to use the underlying
> 'enum cvmx_*' / 'struct cvmx_*' tags directly.
>
> No functional change. Compile-tested with CONFIG_COMPILE_TEST=y and
> CONFIG_OCTEON_ETHERNET=m on x86_64; both default and W=1 builds are
> clean.

As was stated to others attempting to do this, this should be a patch
series, with one patch per enum changed, right?

thanks,

greg k-h