Re: [PATCH 03/11] staging: rtl8723bs: os_dep: fix spacing around operators

[Luka Gejak]

On April 26, 2026 10:04:54 PM GMT+02:00, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>On Mon, Apr 13, 2026 at 12:14:24PM +0200, luka.gejak@xxxxxxxxx wrote:
>> From: Luka Gejak <luka.gejak@xxxxxxxxx>
>> 
>> Fix spaces around operators in the os_dep directory to adhere to the
>> Linux kernel coding style. This resolves multiple spacing warnings
>> reported by checkpatch.pl.
>> 
>> Signed-off-by: Luka Gejak <luka.gejak@xxxxxxxxx>
>> ---
>>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +-
>>  drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
>> index d0feb28b7043..95523c3a508b 100644
>> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
>> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
>> @@ -77,7 +77,7 @@ static int sdio_alloc_irq(struct dvobj_priv *dvobj)
>>  
>>  	sdio_release_host(func);
>>  
>> -	return err?_FAIL:_SUCCESS;
>> +	return err ? _FAIL : _SUCCESS;
>>  }
>>  
>>  static void sdio_free_irq(struct dvobj_priv *dvobj)
>> diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
>> index f9c4d487badf..ce835802c442 100644
>> --- a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
>> +++ b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
>> @@ -93,7 +93,7 @@ static int _rtw_reg_notifier_apply(struct wiphy *wiphy,
>>  
>>  static const struct ieee80211_regdomain *_rtw_regdomain_select(struct
>>  							       rtw_regulatory
>> -							       *reg)
>> + * reg)
>
>What just happened?  How was this generated?  What tool did you use?
>
>And this series is way too big.  Please break it up into smaller parts
>per patch.
>
>thanks,
>
>greg k-h

Hi Greg,
I used vscode's find and replace and I think when I clicked a shortcut
to replace all I might have mistimed it and it registred enter 
instead. And space between * and reg is introduces by same feature,
which is my mistake for not catching before sending. I will fix it and 
split this series into multiple ones.
Best regard,
Luka Gejak