Re: [PATCH v4] staging: octeon: remove SPI, POW, and PKO typedef enums

[Maxwell Doose]

Hi Greg,

On Sun, Apr 26, 2026 at 10:50 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> How was this tested given that the previous ones all were not?
>

What ended up happening was when I did my test compilation, I'd
forgotten to compile the arch/mips half of the driver. The test bot
obviously then caught that and it ended up being fixed. It's also
important to keep in mind that this is (or was, rather) my first
*ever* patch, I hadn't learned all of the tools of the kernel yet. I'm
almost certain that this revision is sound, as the test bot hasn't
reported any errors or warnings, and Dan Carpenter hasn't asked for
any naming changes.

> Also, this should be one commit per enum, right?  Why not make this a
> patch series?

It /should/, but again, this was my first patch. Obviously for the
future that won't be my excuse again, but I agree now that this should
be a patch series.

Also, I think this v4 will be my last revision of this patch. The
integration between arch/mips and drivers/staging has some serious
friction and I think I need to go focus on the subsystems that I can
actually make positive change in.

best regards,
maxwell