Re: [PATCH v4] staging: octeon: remove SPI, POW, and PKO typedef enums

[Dan Carpenter]

On Sun, Apr 26, 2026 at 11:46:27PM -0500, Maxwell Doose wrote:
> Hi Greg,
> 
> On Sun, Apr 26, 2026 at 10:50 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > How was this tested given that the previous ones all were not?
> >
> 
> What ended up happening was when I did my test compilation, I'd
> forgotten to compile the arch/mips half of the driver. The test bot
> obviously then caught that and it ended up being fixed. It's also
> important to keep in mind that this is (or was, rather) my first
> *ever* patch, I hadn't learned all of the tools of the kernel yet. I'm
> almost certain that this revision is sound, as the test bot hasn't
> reported any errors or warnings, and Dan Carpenter hasn't asked for
> any naming changes.

I don't care about the naming so long as you don't have two enums
with the same name where one ends in _e (which stands for enum).
But I also haven't looked at this code at all.

regards,
dan carpenter