Re: [PATCH v2] staging: greybus:add missing newline in sysfs show() output
From: Dan Carpenter
Date: Fri May 01 2026 - 12:54:12 EST
On Fri, May 01, 2026 at 10:15:57PM +0530, Shyam Sunder Reddy Padira wrote:
> Hi Dan Carpenter
>
> I have not been able to test this on hardware. I based this change on
> the standard sysfs formatting requirement as documented in
> Documentation/filesystems/sysfs.rst.
> If there is a concern that specific Greybus userspace tools are
> sensitive to the trailing newline, I can withdraw the patch. However,
> this change aligns the driver with the standard sysfs formatting used
> across the kernel.
You need to test it with the Greybus userspace tools, yes.
regards,
dan carpenter