Re: [PATCH v2] staging: greybus:add missing newline in sysfs show() output

[Shyam Sunder Reddy Padira]

Hi Dan Carpenter and everyone,

I understand the need for verification.
Unfortunately, I do not have access to the physical hardware to test
this specific Greybus driver myself.

Would anyone on the CC list who has access to the hardware would be
willing to run a quick test with the userspace tools.

If not, I am happy to withdraw the patch for now to avoid any risk of
regression.

Best Regards,
Shyam

On Fri, 1 May 2026 at 22:23, Dan Carpenter <error27@xxxxxxxxx> wrote:
>
> On Fri, May 01, 2026 at 10:15:57PM +0530, Shyam Sunder Reddy Padira wrote:
> > Hi Dan Carpenter
> >
> > I have not been able to test this on hardware. I based this change on
> > the standard sysfs formatting requirement as documented in
> > Documentation/filesystems/sysfs.rst.
> > If there is a concern that specific Greybus userspace tools are
> > sensitive to the trailing newline, I can withdraw the patch. However,
> > this change aligns the driver with the standard sysfs formatting used
> > across the kernel.
>
> You need to test it with the Greybus userspace tools, yes.
>
> regards,
> dan carpenter
>