Re: [PATCH v4 0/8] iio: light: si1133: driver cleanup
From: Andy Shevchenko
Date: Mon May 04 2026 - 05:00:23 EST
On Thu, Apr 30, 2026 at 05:04:20PM +0200, Joshua Crofts via B4 Relay wrote:
> This series deals with the cleanup and modernization of the Silicon
> Labs SI1133 UV/Ambient light sensor.
>
> What seemed like a simple checkpatch cleanup turned out to be more
> complex, therefore I've ended up doing a patch series instead.
>
> Changes include:
> - adding missing headers
> - removing unused macros
> - adding guard(mutex)() support
> - code style fixes
> - race condition fixes reported by Sashiko
I'm not sure about patches 1 & 2 without testing on HW (the reports sound good
and fixes look reasonable, but it might be some behaviour that relies on a
[buggy] implementation). Also not sure about patch 7, however don't care much.
For the rest feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko