Re: [PATCH v4 0/8] iio: light: si1133: driver cleanup

[Joshua Crofts]

On Mon, 4 May 2026 at 10:55, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Thu, Apr 30, 2026 at 05:04:20PM +0200, Joshua Crofts via B4 Relay wrote:
> > This series deals with the cleanup and modernization of the Silicon
> > Labs SI1133 UV/Ambient light sensor.
> >
> > What seemed like a simple checkpatch cleanup turned out to be more
> > complex, therefore I've ended up doing a patch series instead.
> >
> > Changes include:
> >  - adding missing headers
> >  - removing unused macros
> >  - adding guard(mutex)() support
> >  - code style fixes
> >  - race condition fixes reported by Sashiko
>
> I'm not sure about patches 1 & 2 without testing on HW (the reports sound good
> and fixes look reasonable, but it might be some behaviour that relies on a
> [buggy] implementation). Also not sure about patch 7, however don't care much.
> For the rest feel free to add
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Hmm, yes, it would be better to test it on HW, too bad the chip is obsolete...

-- 
Kind regards

CJD