Re: [PATCH v4 00/28] KVM: combined patchset for MBEC/GMET support
From: Jon Kohler
Date: Mon May 04 2026 - 21:14:40 EST
> On Apr 30, 2026, at 8:08 AM, David Riley <d.riley@xxxxxxxxxxx> wrote:
>
> On 4/30/26 12:27 PM, Paolo Bonzini wrote:
>> On Wed, Apr 29, 2026 at 3:05 PM David Riley <d.riley@xxxxxxxxxxx> wrote:
>>> I observed the following:
>>> The guest now never actually boots into Windows. It gets stuck before
>>> that and therefore does not even enter Windows Recovery.
>> Last minute rebase screwup. The old code had:
>>
>> vmcb02->control.misc_ctl = vmcb01->control.misc_ctl & SVM_MISC_ENABLE_NP;
>>
>> New code has:
>>
>> vmcb02->control.misc_ctl = vmcb01->control.misc_ctl & SVM_MISC_ENABLE_NP;
>>
>> And now needs to pass down GMET as well.
>
> Thanks for looking into it.
> I changed the line to:
>
> vmcb02->control.misc_ctl = vmcb01->control.misc_ctl & (SVM_MISC_ENABLE_NP | SVM_MISC_ENABLE_GMET);
>
> and was able to start the Windows VM with VBS enabled.
>
>> Paolo
>>
>>
Good stuff, thanks, David.
Paolo - Any chance you’ve got the next series ready? I can get that
into the QA harness on our side to beat it up. I was going to do that
with the latest series now that I’m back from holiday, but figured
I’d ask since there was discussion of some fixups with Sean last week?
Thanks,
Jon