Re: [PATCH net-next] e1000e: ethtool: add get_channels support
From: Jon Kohler
Date: Mon May 04 2026 - 21:20:20 EST
> On May 4, 2026, at 7:49 PM, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Mon, 4 May 2026 08:48:23 -0700 Jon Kohler wrote:
>> e1000e hardware supports a single RX/TX queue pair, add basic support
>> for ethtool -l (i.e. get_channels), so that callers indeed see a single
>> queue.
>
> Why? Isn't EOPNOTSUP from ethtool -l implicitly saying that there's
> only one queue?
Perhaps, but I’m not sure that is a guarantee. A good relevant example
is when I added get_channels support to enic, which supports all sorts
of channels, so I don’t think EOPNOTSUP can be 100% consider reliable
in that case. Meaning, if it just so happens that the original author(s)
didn't put in get_channels, that doesn’t necessarily mean there is only
one queue.
And in this case, there is an "other" queue as as well too, as far as
I can tell, so the output is at least semi-interesting.
Jon