Re: [PATCH net] net: usb: asix: ax88772: re-add usbnet_link_change() in phylink callbacks

[Baier, Markus]

Hello,


for your information, the current version of the patch goes a bit too far,
as using the "usbnet_link_change" function in this context.
called from the "mac_link_up" or "mac_link_down" functions, works but
is not ideal.

With Oleksij's help, I have since been able to create a new patch
that specifically enables or disables only the RX URB submission.
I will submit the new patch as v2 of the current patch later today
or tomorrow at the latest.
I have completed testing of the new patch, and the results were positive.

PS: Sorry that I sent the first email in HTML format

Best regards
Markus 


Von: patchwork-bot+netdevbpf@xxxxxxxxxx <patchwork-bot+netdevbpf@xxxxxxxxxx>
Gesendet: Dienstag, 5. Mai 2026 04:20:07
An: Baier, Markus
Cc: o.rempel@xxxxxxxxxxxxxx; andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; linux@xxxxxxxxxxxxxxx; enelsonmoore@xxxxxxxxx; linmq006@xxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Betreff: Re: [PATCH net] net: usb: asix: ax88772: re-add usbnet_link_change() in phylink callbacks
    
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Fri,  1 May 2026 18:39:41 +0200 you wrote:
> Commit e0bffe3e6894 ("net: asix: ax88772: migrate to phylink") replaced
> the asix_adjust_link() PHY callback with phylink's mac_link_up() and
> mac_link_down() handlers, but did not carry over the usbnet_link_change()
> notification that commit 805206e66fab ("net: asix: fix "can't send until
> first packet is send" issue") had added.
> 
> As a result, the original symptom returns: when the link comes up,
> usbnet is never notified, so the RX URB submission stays dormant until
> some other event (e.g. a transmitted packet triggering the status
> endpoint interrupt) wakes it up.
> 
> [...]

Here is the summary with links:
  - [net] net: usb: asix: ax88772: re-add usbnet_link_change() in phylink callbacks
    https://git.kernel.org/netdev/net/c/36bdc0e815b4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html