RE: [PATCH 5/7] pinctrl: renesas: rzg2l: Fix type in .pin_config_group_get() callback

[Prabhakar Mahadev Lad]

> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Sent: 30 April 2026 16:33
> To: Linus Walleij <linusw@xxxxxxxxxx>; Lorenzo Bianconi
> <lorenzo@xxxxxxxxxx>; Sean Wang <sean.wang@xxxxxxxxxx>; Paul Cercueil
> <paul@xxxxxxxxxxxxxxx>; Tony Lindgren <tony@xxxxxxxxxxx>; Haojian Zhuang
> <haojian.zhuang@xxxxxxxxxx>; Matthias Brugger <matthias.bgg@xxxxxxxxx>;
> AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>;
> Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-mips@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; linux-renesas-
> soc@xxxxxxxxxxxxxxx; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Subject: [PATCH 5/7] pinctrl: renesas: rzg2l: Fix type in
> .pin_config_group_get() callback
> 
> On 64-bit platforms, "unsigned long" is 64-bit.  Hence checking if all
> "unsigned long" configuration values are equal should be done using an
> "unsigned long" temporary.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
>  drivers/pinctrl/renesas/pinctrl-rzg2l.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Cheers,
Prabhakar
 
> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index bc2154b695149809..5b0f23af5a6cc9de 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -1647,8 +1647,9 @@ static int rzg2l_pinctrl_pinconf_group_get(struct
> pinctrl_dev *pctldev,
>  					   unsigned int group,
>  					   unsigned long *config)
>  {
> +	unsigned long prev_config = 0;
>  	const unsigned int *pins;
> -	unsigned int i, npins, prev_config = 0;
> +	unsigned int i, npins;
>  	int ret;
> 
>  	ret = pinctrl_generic_get_group_pins(pctldev, group, &pins, &npins);
> --
> 2.43.0