Re: [PATCH v3] iio: humidity: ens210: Fix missing I2C functionality checks

[Maxwell Doose]

On Wed, May 6, 2026 at 10:43 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Wed, May 06, 2026 at 10:02:29AM -0500, Maxwell Doose wrote:
> > On Wed, May 6, 2026 at 3:40 AM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxx> wrote:
> > > On Wed, May 06, 2026 at 11:39:11AM +0300, Andy Shevchenko wrote:
> > > > On Tue, May 05, 2026 at 06:49:43PM +0100, Salah Triki wrote:
>
> ...
>
> > > > > +                           !i2c_check_functionality(client->adapter,
> > > > > +                                   I2C_FUNC_SMBUS_EMUL)) {
> > > >
> > > > This one is now wrong.
> > >
> > > I meant this *indentation* is now wrong.
> >
> > Did something happen to that when I sent the email? Or maybe I'm just
> > going insane...
>
> Sounds like latter one? :-)
>

Probably true :)
In all seriousness though I need to slow down...

>
> > slightly confused,
>
> In short this is `if (foo(A) && foo(B))`, and foo should be indented on the
> same column while their parameters on different but still same. In your example
> the foo(B) is indented as A parameter on previous call instead of indenting as
> foo(...).
>

Mk, thanks for pointing that out to me.

best regards,
max



> --
> With Best Regards,
> Andy Shevchenko
>
>