Re: [PATCH net-next v6 00/10] enic: SR-IOV V2 admin channel and MBOX protocol

[Simon Horman]

On Sun, May 03, 2026 at 04:22:37AM -0700, Satish Kharat wrote:
> This series adds the admin channel infrastructure and mailbox (MBOX)
> protocol needed for V2 SR-IOV support in the enic driver.
> 
> The V2 SR-IOV design uses a direct PF-VF communication channel built on
> dedicated WQ/RQ/CQ hardware resources and an MSI-X interrupt.
> 
> Firmware capability and admin channel infrastructure (patches 1-4):
>   - Probe-time firmware feature check for V2 SR-IOV support
>   - Admin channel open/close, RQ buffer management, CQ service
>     with MSI-X interrupt and NAPI polling
> 
> MBOX protocol and VF enable (patches 5-10):
>   - MBOX message types, core send/receive, PF and VF handlers
>   - V2 SR-IOV enable wiring with admin channel setup
>   - V2 VF probe with admin channel and PF registration
> 
> Signed-off-by: Satish Kharat <satishkh@xxxxxxxxx>

Hi Satish,

There is are AI-generated reviews of this patch available at both
https://netdev-ai.bots.linux.dev/sashiko/ and https://sashiko.dev/
And it seems to me that some of the issues raised there do warrant
investigation. I'd appreciate it if you could do so with
a view to addressing any issues that are not pre-existing in v7.

...