Re: [PATCH net-next 2/3] ppp: unify two channel structs

From: Sebastian Andrzej Siewior

Date: Thu May 07 2026 - 03:42:07 EST


On 2026-05-07 13:53:30 [+0800], Qingfang Deng wrote:
> > This patch is IMHO a bit too big and should be split. Also this kind of
> > refactor looks very invasive and potentially regression prone. I think
> > it should include a signficant self-test coverage increase.
> This is indeed too big. But how do I split it without breaking the build?

The current ppp tests would yell if you accidentally broke something?

Sebastian