Re: [PATCH net-next 2/3] ppp: unify two channel structs
From: Qingfang Deng
Date: Thu May 07 2026 - 04:42:04 EST
On 2026/5/7 15:40, Sebastian Andrzej Siewior wrote:
On 2026-05-07 13:53:30 [+0800], Qingfang Deng wrote:By "breaking the build" I meant compile-time errors (due to API changes).
The current ppp tests would yell if you accidentally broke something?This patch is IMHO a bit too big and should be split. Also this kind ofThis is indeed too big. But how do I split it without breaking the build?
refactor looks very invasive and potentially regression prone. I think
it should include a signficant self-test coverage increase.