Re: [PATCH] selftests/mm: Fix mmap() return value check in run_migration_benchmark

[SeongJae Park]

On Tue, 12 May 2026 18:13:05 +0800 Hongfu Li <lihongfu@xxxxxxxxxx> wrote:

> mmap() returns MAP_FAILED on error, not NULL.  The current check uses
> !buffer->ptr, which evaluates to false when mmap() fails (since
> MAP_FAILED is (void *)-1, not 0), so the error path is never taken.

Good catch, thank you!

> 
> Signed-off-by: Hongfu Li <lihongfu@xxxxxxxxxx>

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>


Thanks,
SJ

[...]