Re: [PATCH v6 14/16] ASoC: rsnd: src: Add SRC reset and clock support for RZ/G3E

[Kuninori Morimoto]

Hi John

Thank you for the patch

> The RZ/G3E SoC requires explicit SCU (Sampling Rate Converter Unit)
> reset and clock management unlike previous R-Car generations:
> 
>  - scu: SCU top-level module clock (CPG_CLKON_15.CLK6_ON)
>  - scu_x2: SCU top-level double-rate clock (CPG_CLKON_15.CLK7_ON)
>  - scu_supply: SCU register-access / housekeeping clock
>    (CPG_CLKON_23.CLK14_ON, described by the HW manual as the system
>    clock for "function modules excluding SRC0-9, DVC0-1, CTU0-1 and
>    MIX0-1 (including the setting registers, etc.)")
> 
> Without every one of them enabled, no SCU register is reachable.
> Add support for the shared SCU reset controller used by all SRC
> modules on the RZ/G3E SoC and manage scu_supply with the same lifetime
> as scu and scu_x2. This matches the hardware description and avoids
> unnecessary clock toggling.
> 
> Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> ---

I guess this patch has 2 features.

	(A) add rsnd_src_ctrl
	(B) add rstc

These are independent ?

And in (A), I guess no one is using scu_supply ?
If it is just for lifetime, and is necessary, could you please add such
comment ?

(A) can be merged into [16/16] ? or be as "prepare patch".

Thank you for your help !!

Best regards
---
Kuninori Morimoto