[PATCH 2/2] dt-bindings: interconnect: qcom,x1e80100-rpmh: Revert ABI break
From: Krzysztof Kozlowski
Date: Wed May 20 2026 - 18:04:27 EST
Revert commit c83cf1b1c6f1 ("dt-bindings: interconnect:
qcom,x1e80100-rpmh: add clocks property to enable QoS") because it
breaks the ABI without justification what was broken and what was not
working. It claims the clocks are needed for QoS, which might be
correct, but QoS itself is not a mandatory thing for the device to
operate.
Fixes: c83cf1b1c6f1 ("dt-bindings: interconnect: qcom,x1e80100-rpmh: add clocks property to enable QoS")
Closes: https://krzk.eu/#/builders/102/builds/70/steps/23/logs/warnings__3_
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
---
.../interconnect/qcom,x1e80100-rpmh.yaml | 62 -------------------
1 file changed, 62 deletions(-)
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,x1e80100-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,x1e80100-rpmh.yaml
index 27d9234bc762..0840b0ec6e27 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,x1e80100-rpmh.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,x1e80100-rpmh.yaml
@@ -46,10 +46,6 @@ properties:
reg:
maxItems: 1
- clocks:
- minItems: 1
- maxItems: 6
-
required:
- compatible
@@ -69,63 +65,6 @@ allOf:
required:
- reg
- - if:
- properties:
- compatible:
- contains:
- enum:
- - qcom,x1e80100-aggre1-noc
- then:
- properties:
- clocks:
- items:
- - description: aggre UFS PHY AXI clock
-
- - if:
- properties:
- compatible:
- contains:
- enum:
- - qcom,x1e80100-usb-north-anoc
- then:
- properties:
- clocks:
- items:
- - description: aggre USB2 PRIM AXI clock
- - description: aggre USB3 MP AXI clock
-
- - if:
- properties:
- compatible:
- contains:
- enum:
- - qcom,x1e80100-usb-south-anoc
- then:
- properties:
- clocks:
- items:
- - description: aggre USB3 PRIM AXI clock
- - description: aggre USB3 SEC AXI clock
- - description: aggre USB3 TERT AXI clock
- - description: aggre USB4_0 AXI clock
- - description: aggre USB4_1 AXI clock
- - description: aggre USB4_2 AXI clock
-
- - if:
- properties:
- compatible:
- contains:
- enum:
- - qcom,x1e80100-aggre1-noc
- - qcom,x1e80100-usb-north-anoc
- - qcom,x1e80100-usb-south-anoc
- then:
- required:
- - clocks
- else:
- properties:
- clocks: false
-
unevaluatedProperties: false
examples:
@@ -141,5 +80,4 @@ examples:
reg = <0x016e0000 0x14400>;
#interconnect-cells = <2>;
qcom,bcm-voters = <&apps_bcm_voter>;
- clocks = <&gcc_aggre_ufs_phy_axi_clk>;
};
--
2.53.0