Re: [PATCH 1/2] interconnect: qcom: x1e80100: Revert ABI break

From: Konrad Dybcio

Date: Thu May 21 2026 - 04:00:15 EST


On 5/20/26 8:49 PM, Krzysztof Kozlowski wrote:
> Revert commit c70f7dcd0921 ("interconnect: qcom: x1e80100: enable QoS
> configuration") because it breaks the ABI without justification what was
> broken and what was not working. It claims the clocks are needed for
> QoS, which might be correct, but QoS itself is not a mandatory thing for
> the device to operate.

???

Would a saner resolution not be to simply adjust the bindings change to
mimic the other post-factum QoS clock additions, where `required:`
wasn't altered?

e.g.

e07f3b8c9e1c ("dt-bindings: interconnect: qcom,qcs615-rpmh: add clocks property to enable QoS")

Konrad