Re: [PATCH 1/2] interconnect: qcom: x1e80100: Revert ABI break
From: Krzysztof Kozlowski
Date: Thu May 21 2026 - 06:32:45 EST
On Thu, May 21, 2026 at 10:00:03AM +0200, Konrad Dybcio wrote:
> On 5/20/26 8:49 PM, Krzysztof Kozlowski wrote:
> > Revert commit c70f7dcd0921 ("interconnect: qcom: x1e80100: enable QoS
> > configuration") because it breaks the ABI without justification what was
> > broken and what was not working. It claims the clocks are needed for
> > QoS, which might be correct, but QoS itself is not a mandatory thing for
> > the device to operate.
>
> ???
>
> Would a saner resolution not be to simply adjust the bindings change to
> mimic the other post-factum QoS clock additions, where `required:`
> wasn't altered?
Maybe saner but I am really annoyed with the fact that authors don't
care about dtbs_check rules and impact on users.
Anyway, commits were dropped, so this patchset can be ignored.
Best regards,
Krzysztof