Re: [PATCH 2/3] riscv: dts: spacemit: k1: Split gmac_clk_ref into independent pinctrl groups

[Yixun Lan]

Hi Junhui,

On 18:01 Fri 22 May     , Junhui Liu wrote:
> The gmac_clk_ref signal is optional for the GMAC controller and is not
> strictly required for all hardware designs. In several already
> upstreamed K1 boards, this signal remains unconnected or the
> corresponding resistor is marked as NC.
> 
I've not checked all exist boards which already accepted by mainline,
but just ask, to be sure, none of them actually used clk ref pin?
otherwise we will result with a broken GMAC/Ethernet driver..

> Furthermore, the pins for gmac0_clk_ref (GPIO 45) and gmac1_clk_ref
> (GPIO 46) may be used as GPIOs for other functions even when the
> Ethernet controller is active. Splitting these into independent groups
> avoids pinmux conflicts and allows boards to use the reference clock
> signal only when it is actually needed.
> 

> Fixes: 60775f28cfb7 ("riscv: dts: spacemit: Add Ethernet support for K1")
> Signed-off-by: Junhui Liu <junhui.liu@xxxxxxxxxxxxx>

-- 
Yixun Lan (dlan)