Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add AD5529R

[Jonathan Cameron]

On Mon, 25 May 2026 17:30:02 +0100
Conor Dooley <conor@xxxxxxxxxx> wrote:

> On Fri, May 22, 2026 at 06:02:07PM +0100, Jonathan Cameron wrote:
> > On Tue, 19 May 2026 17:42:58 +0200
> > Janani Sunil <janani.sunil@xxxxxxxxxx> wrote:
> >   
> > > Devicetree bindings for AD5529R 16 channel 12/16 bit high voltage,
> > > buffered voltage output digital-to-analog converter (DAC) with an
> > > integrated precision reference.  
> > 
> > Note that I'm seeing this as Changes Requested in the DT-binding patchwork
> > but didn't see any replies.
> > 
> > Seems I didn't get the sashiko reply - nor did the IIO patchwork.
> > Hopefully Janani did!
> > https://patchwork.kernel.org/project/devicetree/patch/20260519-ad5529r-driver-v3-1-267c0731aa68@xxxxxxxxxx/  
> 
> The sashiko stuff is per subsystem or something, so dt stuff only goes
> to us and the submitters. I think that's kinda stupid but also probably
> required to avoid pissing people off. There's quite a bit of noise
> generated by it, especially with it repeating the same incorrect stuff
> on every version.

When I get on top of the long weekend's backlog I'll start a discussion
on whether we ask for emails from Sashiko be sent to linux-iio.

I was nervous about doing that until I had some experience of how 
reliable the reviews are but given I'm either cutting and pasting stuff
into threads or telling people to go look, might as well have those emails.

Jonathan

> 
> >   
> > > 
> > > Signed-off-by: Janani Sunil <janani.sunil@xxxxxxxxxx>
> > > ---
> > >  .../devicetree/bindings/iio/dac/adi,ad5529r.yaml   | 217 +++++++++++++++++++++
> > >  MAINTAINERS                                        |   7 +
> > >  2 files changed, 224 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml
> > > new file mode 100644
> > > index 000000000000..eb66f6ca063d
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml
> > > @@ -0,0 +1,217 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5529r.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices AD5529R 16-Channel 12/16-bit High Voltage DAC
> > > +
> > > +maintainers:
> > > +  - Janani Sunil <janani.sunil@xxxxxxxxxx>
> > > +
> > > +description: |
> > > +  The AD5529R is a 16-channel, 12-bit or 16-bit, high voltage, buffered voltage output  
> > 
> > Long line. Check the wrap.
> >   
> > > +  digital-to-analog converter (DAC) with an integrated precision reference.
> > > +  The device operates from unipolar and bipolar supplies. It is guaranteed
> > > +  monotonic and has built-in rail-to-rail output buffers that can source or
> > > +  sink up to 25mA.
> > > +
> > > +  Specifications:
> > > +  * 16 independent 12-bit or 16-bit DAC channels
> > > +  * Independently programmable output ranges: 0V to 5V, 0V to 10V, 0V to 20V,
> > > +    0V to 40V, ±5V, ±10V, ±15V, and ±20V
> > > +  * The device supports SPI communication with Mode 0 and Mode 3.
> > > +  * 4.096V precision reference, 12ppm/°C maximum
> > > +  * Built-in function generation: Toggle, Sinusoidal Dither, and Ramp waveforms
> > > +  * Multiplexer for output voltage, load current sense and die temperature
> > > +
> > > +  Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad5529r.pdf
> > > +  
> >   
> > > +patternProperties:
> > > +  "^channel@([0-9]|1[0-5])$":  
> > 
> > Sashiko commented that this should be hex.  Why the forcing to decimal?
> >