Re: [EXTERNAL] Re: [PATCH rdma-next v2] RDMA/mana_ib: hardening: Clamp adapter capability values from MANA_IB_GET_ADAPTER_CAP

From: Erni Sri Satya Vennela

Date: Tue May 26 2026 - 10:59:41 EST


On Mon, May 25, 2026 at 08:01:55PM -0300, Jason Gunthorpe wrote:
> On Mon, May 25, 2026 at 11:58:17AM -0700, Erni Sri Satya Vennela wrote:
> > > “There is no reason they should be signed, you should just fix the
> > > type.”
> >
> > It is not allowed to change sign in props, so clamping is the best bet.
>
> Why not? Fix the core code, it is just old junk they are signed, they
> should't never have been.
>
> Jason

Thanks for the feedback, Jason.

I sent the v3 before your comments in v2.
I'll be sending a v4 which drops the clamping entirely.

- Vennela