Re: [PATCH 0/2] xfs: fix CoW fork repair error handling

From: Carlos Maiolino

Date: Tue May 26 2026 - 10:59:51 EST


On Tue, May 26, 2026 at 08:32:41PM +0800, Yingjie Gao wrote:
> Hi all,
>
> This series fixes two error handling bugs in the CoW fork repair code.
>
> The non-realtime helper can lose real failures in two different ways:
> it returns success after the common cleanup labels, and the
> force-rebuild path can return directly without freeing the AG repair
> context.
>
> The realtime helper has a related cleanup bug in its force-rebuild
> path. If marking the full mapping fails, the code jumps past the
> rtgroup scrub cleanup and only drops the local rtgroup reference.
>
> Split the fixes into two patches so that the non-RT and RT changes
> remain easy to review and bisect independently.
>
> Patches in this series:
> 1. fix non-RT CoW fork repair error returns and cleanup
> 2. fix RT CoW fork repair cleanup

Was this generated by any LLM model?

>
> Thanks,
> Yingjie
>
> Yingjie Gao (2):
> xfs: fix error returns in CoW fork repair
> xfs: fix rtgroup cleanup in CoW fork repair
>
> fs/xfs/scrub/cow_repair.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --
> 2.20.1
>