Re: [PATCH v3 4/5] driver core: Allow the constification of device attributes

[Mark Brown]

On Tue, May 12, 2026 at 06:39:14PM +0200, Thomas Weißschuh wrote:

> Allow device attribute to reside in read-only memory.
> Both const and non-const attributes are handled by the utility macros
> and attributes can be migrated one-by-one.

I'm seeing NFS boot breaks in -next on at least the libre.computer
tritium which bisect to this commit.  I don't immediately see what this
commit might have done to cause a boot break, but I did get two
different bisects going to the same commit which set off my alarm bells.
The boot grinds to a halt when it gets to the end of userspace bringup:

| getty@ttyS0.service;invocationid=c161395710bf441d8427be13d54aa849;type=service\P+q6E616D65\
| Debian GNU/Linux forky/sid debian-testing-arm64 ttyS0
| debian-testing-arm64 login: root (automatic login)
| Linux debian-testing-arm64 7.1.0-rc5-next-20260525 #1 SMP PREEMPT @1779724722 aarch64
| The programs included with the Debian GNU/Linux system are free software;
| the exact distribution terms for each program are described in the
| individual files in /usr/share/doc/*/copyright.
| Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
| permitted by applicable law.

then no prompt appears.

Full log:

   https://lava.sirena.org.uk/scheduler/job/2796935#L2638

Bisect log:

# bad: [d387b06f7c15b4639244ad66b4b0900c6a02b430] Add linux-next specific files for 20260525
# good: [c745c46074da99cdcef8c1fc6093030c6f9d7143] Merge branch 'for-linux-next-fixes' of https://gitlab.freedesktop.org/drm/misc/kernel.git
# good: [34808ac8ddafc3e2c2a59e84eaab0a410e7a0fdc] regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16
git bisect start 'd387b06f7c15b4639244ad66b4b0900c6a02b430' 'c745c46074da99cdcef8c1fc6093030c6f9d7143' '34808ac8ddafc3e2c2a59e84eaab0a410e7a0fdc'
# test job: [34808ac8ddafc3e2c2a59e84eaab0a410e7a0fdc] https://lava.sirena.org.uk/scheduler/job/2783529
# test job: [d387b06f7c15b4639244ad66b4b0900c6a02b430] https://lava.sirena.org.uk/scheduler/job/2796935
# bad: [d387b06f7c15b4639244ad66b4b0900c6a02b430] Add linux-next specific files for 20260525
git bisect bad d387b06f7c15b4639244ad66b4b0900c6a02b430
# test job: [4c0ea14d8ec6f6fcb94b7ad9248679ffcf747e9b] https://lava.sirena.org.uk/scheduler/job/2796998
# good: [4c0ea14d8ec6f6fcb94b7ad9248679ffcf747e9b] Merge branch 'libcrypto-next' of https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
git bisect good 4c0ea14d8ec6f6fcb94b7ad9248679ffcf747e9b
# test job: [af3c2d822a4b67034aa47554c178b5ffcf973456] https://lava.sirena.org.uk/scheduler/job/2797090
# good: [af3c2d822a4b67034aa47554c178b5ffcf973456] Merge branch 'for-next' of https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
git bisect good af3c2d822a4b67034aa47554c178b5ffcf973456
# test job: [2f8df83b202ec7f8080a25b2e9da79c3361775fd] https://lava.sirena.org.uk/scheduler/job/2797983
# bad: [2f8df83b202ec7f8080a25b2e9da79c3361775fd] Merge branch 'char-misc-next' of https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
git bisect bad 2f8df83b202ec7f8080a25b2e9da79c3361775fd
# test job: [6b55dddad1ed45d92eef8046156965f7709f0d52] https://lava.sirena.org.uk/scheduler/job/2798041
# good: [6b55dddad1ed45d92eef8046156965f7709f0d52] Merge branch 'next' of git://git.kernel.org/pub/scm/virt/kvm/kvm.git
git bisect good 6b55dddad1ed45d92eef8046156965f7709f0d52
# test job: [6206468c5ba41e14b55d8dfd71af1611398a3399] https://lava.sirena.org.uk/scheduler/job/2798075
# good: [6206468c5ba41e14b55d8dfd71af1611398a3399] Merge branch 'for-next' of https://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext.git
git bisect good 6206468c5ba41e14b55d8dfd71af1611398a3399
# test job: [cbfc1fc9f6d2bd7364610b0077f55f16ff78cbab] https://lava.sirena.org.uk/scheduler/job/2798512
# bad: [cbfc1fc9f6d2bd7364610b0077f55f16ff78cbab] Merge branch 'driver-core-next' of https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git
git bisect bad cbfc1fc9f6d2bd7364610b0077f55f16ff78cbab
# test job: [3c15372851403012d068a6f388770ed98dbe684e] https://lava.sirena.org.uk/scheduler/job/2798558
# good: [3c15372851403012d068a6f388770ed98dbe684e] Merge branch 'for-firmware-next' of https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git
git bisect good 3c15372851403012d068a6f388770ed98dbe684e
# test job: [a9c12b783cc711de3ac7f188bed07d529bb818af] https://lava.sirena.org.uk/scheduler/job/2798584
# good: [a9c12b783cc711de3ac7f188bed07d529bb818af] device core: make struct device_driver groups members constant arrays
git bisect good a9c12b783cc711de3ac7f188bed07d529bb818af
# test job: [25025253476a64c186592d952c27f24bc3490e42] https://lava.sirena.org.uk/scheduler/job/2798628
# good: [25025253476a64c186592d952c27f24bc3490e42] leds: Adjust documentation of brightness sysfs node
git bisect good 25025253476a64c186592d952c27f24bc3490e42
# test job: [13443fbf62414e42afb1675ab2d3b767c6466915] https://lava.sirena.org.uk/scheduler/job/2798847
# good: [13443fbf62414e42afb1675ab2d3b767c6466915] driver core: Stop using generic sysfs macros for device attributes
git bisect good 13443fbf62414e42afb1675ab2d3b767c6466915
# test job: [314537a0cd78d7a07f6e7ce7dcc0ce340e41fb2c] https://lava.sirena.org.uk/scheduler/job/2798892
# good: [314537a0cd78d7a07f6e7ce7dcc0ce340e41fb2c] Merge branch 'for-next' of https://github.com/cminyard/linux-ipmi.git
git bisect good 314537a0cd78d7a07f6e7ce7dcc0ce340e41fb2c
# test job: [024480bf8d75bd16894c5b0eb6082b6e6dae4970] https://lava.sirena.org.uk/scheduler/job/2799135
# bad: [024480bf8d75bd16894c5b0eb6082b6e6dae4970] driver core: Constify core device attributes
git bisect bad 024480bf8d75bd16894c5b0eb6082b6e6dae4970
# test job: [434506b86a6cde84a0ef19daa9e3b1926e2f96a9] https://lava.sirena.org.uk/scheduler/job/2799464
# bad: [434506b86a6cde84a0ef19daa9e3b1926e2f96a9] driver core: Allow the constification of device attributes
git bisect bad 434506b86a6cde84a0ef19daa9e3b1926e2f96a9
# first bad commit: [434506b86a6cde84a0ef19daa9e3b1926e2f96a9] driver core: Allow the constification of device attributes

Attachment: signature.asc
Description: PGP signature