Re: [PATCH v3 4/5] driver core: Allow the constification of device attributes

[Mark Brown]

On Tue, May 26, 2026 at 03:52:24PM +0100, Mark Brown wrote:
> On Tue, May 12, 2026 at 06:39:14PM +0200, Thomas Weißschuh wrote:
> 
> > Allow device attribute to reside in read-only memory.
> > Both const and non-const attributes are handled by the utility macros
> > and attributes can be migrated one-by-one.
> 
> I'm seeing NFS boot breaks in -next on at least the libre.computer
> tritium which bisect to this commit.  I don't immediately see what this
> commit might have done to cause a boot break, but I did get two
> different bisects going to the same commit which set off my alarm bells.

I've now got another bisect which comes out to another driver core
commit 1137838865bf (driver core: Use mod_delayed_work to prevent lost
deferred probe work), I don't know that that is an accurate result
either but it does look like there's something fishy in this area.

Log for that bisect:

# bad: [d387b06f7c15b4639244ad66b4b0900c6a02b430] Add linux-next specific files for 20260525
# good: [c745c46074da99cdcef8c1fc6093030c6f9d7143] Merge branch 'for-linux-next-fixes' of https://gitlab.freedesktop.org/drm/misc/kernel.git
# good: [34808ac8ddafc3e2c2a59e84eaab0a410e7a0fdc] regmap-i2c: fix sparse warning in regmap_smbus_word_write_reg16
git bisect start 'd387b06f7c15b4639244ad66b4b0900c6a02b430' 'c745c46074da99cdcef8c1fc6093030c6f9d7143' '34808ac8ddafc3e2c2a59e84eaab0a410e7a0fdc'
# test job: [34808ac8ddafc3e2c2a59e84eaab0a410e7a0fdc] https://lava.sirena.org.uk/scheduler/job/2783502
# test job: [d387b06f7c15b4639244ad66b4b0900c6a02b430] https://lava.sirena.org.uk/scheduler/job/2796934
# bad: [d387b06f7c15b4639244ad66b4b0900c6a02b430] Add linux-next specific files for 20260525
git bisect bad d387b06f7c15b4639244ad66b4b0900c6a02b430
# test job: [4c0ea14d8ec6f6fcb94b7ad9248679ffcf747e9b] https://lava.sirena.org.uk/scheduler/job/2796983
# good: [4c0ea14d8ec6f6fcb94b7ad9248679ffcf747e9b] Merge branch 'libcrypto-next' of https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
git bisect good 4c0ea14d8ec6f6fcb94b7ad9248679ffcf747e9b
# test job: [af3c2d822a4b67034aa47554c178b5ffcf973456] https://lava.sirena.org.uk/scheduler/job/2797058
# good: [af3c2d822a4b67034aa47554c178b5ffcf973456] Merge branch 'for-next' of https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
git bisect good af3c2d822a4b67034aa47554c178b5ffcf973456
# test job: [2f8df83b202ec7f8080a25b2e9da79c3361775fd] https://lava.sirena.org.uk/scheduler/job/2797982
# bad: [2f8df83b202ec7f8080a25b2e9da79c3361775fd] Merge branch 'char-misc-next' of https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
git bisect bad 2f8df83b202ec7f8080a25b2e9da79c3361775fd
# test job: [6b55dddad1ed45d92eef8046156965f7709f0d52] https://lava.sirena.org.uk/scheduler/job/2798010
# good: [6b55dddad1ed45d92eef8046156965f7709f0d52] Merge branch 'next' of git://git.kernel.org/pub/scm/virt/kvm/kvm.git
git bisect good 6b55dddad1ed45d92eef8046156965f7709f0d52
# test job: [6206468c5ba41e14b55d8dfd71af1611398a3399] https://lava.sirena.org.uk/scheduler/job/2798076
# good: [6206468c5ba41e14b55d8dfd71af1611398a3399] Merge branch 'for-next' of https://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext.git
git bisect good 6206468c5ba41e14b55d8dfd71af1611398a3399
# test job: [cbfc1fc9f6d2bd7364610b0077f55f16ff78cbab] https://lava.sirena.org.uk/scheduler/job/2798520
# bad: [cbfc1fc9f6d2bd7364610b0077f55f16ff78cbab] Merge branch 'driver-core-next' of https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git
git bisect bad cbfc1fc9f6d2bd7364610b0077f55f16ff78cbab
# test job: [3c15372851403012d068a6f388770ed98dbe684e] https://lava.sirena.org.uk/scheduler/job/2798573
# good: [3c15372851403012d068a6f388770ed98dbe684e] Merge branch 'for-firmware-next' of https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git
git bisect good 3c15372851403012d068a6f388770ed98dbe684e
# test job: [a9c12b783cc711de3ac7f188bed07d529bb818af] https://lava.sirena.org.uk/scheduler/job/2798622
# good: [a9c12b783cc711de3ac7f188bed07d529bb818af] device core: make struct device_driver groups members constant arrays
git bisect good a9c12b783cc711de3ac7f188bed07d529bb818af
# test job: [25025253476a64c186592d952c27f24bc3490e42] https://lava.sirena.org.uk/scheduler/job/2798651
# good: [25025253476a64c186592d952c27f24bc3490e42] leds: Adjust documentation of brightness sysfs node
git bisect good 25025253476a64c186592d952c27f24bc3490e42
# test job: [13443fbf62414e42afb1675ab2d3b767c6466915] https://lava.sirena.org.uk/scheduler/job/2798921
# bad: [13443fbf62414e42afb1675ab2d3b767c6466915] driver core: Stop using generic sysfs macros for device attributes
git bisect bad 13443fbf62414e42afb1675ab2d3b767c6466915
# test job: [81e7c6befa36cecdcbf7244393bd67e8f8c59bf5] https://lava.sirena.org.uk/scheduler/job/2799138
# bad: [81e7c6befa36cecdcbf7244393bd67e8f8c59bf5] of: dynamic: Fix overlayed devices not probing because of fw_devlink
git bisect bad 81e7c6befa36cecdcbf7244393bd67e8f8c59bf5
# test job: [1137838865bfc9a7cd5869c1dc5c22aa45ec12c8] https://lava.sirena.org.uk/scheduler/job/2799476
# bad: [1137838865bfc9a7cd5869c1dc5c22aa45ec12c8] driver core: Use mod_delayed_work to prevent lost deferred probe work
git bisect bad 1137838865bfc9a7cd5869c1dc5c22aa45ec12c8
# test job: [9582485a65eacfd7245ec7f0a9d7e2c34749d669] https://lava.sirena.org.uk/scheduler/job/2799512
# good: [9582485a65eacfd7245ec7f0a9d7e2c34749d669] device property: fix fwnode reference leak in fwnode_graph_get_endpoint_by_id()
git bisect good 9582485a65eacfd7245ec7f0a9d7e2c34749d669
# first bad commit: [1137838865bfc9a7cd5869c1dc5c22aa45ec12c8] driver core: Use mod_delayed_work to prevent lost deferred probe work

Attachment: signature.asc
Description: PGP signature