Re: [PATCH v1] can: flexcan: Drop unused platform driver data

[Marc Kleine-Budde]

On 28.05.2026 11:45:39, Uwe Kleine-König (The Capable Hub) wrote:
> No function in the flexcan driver ever accesses the .driver_data member
> of its .id_table array as device_get_match_data() returns NULL for
> non-of platform devices. So drop that unused assignment.
>
> While touching that array, drop the trailing comma after the terminator
> entry.

Does this mean that commit 5e6c3454b405 ("net: can: Use
device_get_match_data()") introduced a regression?

Marc

>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> Hello,
>
> I found this patch opportunity while working on a cleanup quest that has
> unifying platform_device_id arrays as first step.
>
> Best regards
> Uwe
>  drivers/net/can/flexcan/flexcan-core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
> index f5d22c61503f..1871def90fe3 100644
> --- a/drivers/net/can/flexcan/flexcan-core.c
> +++ b/drivers/net/can/flexcan/flexcan-core.c
> @@ -2077,10 +2077,9 @@ MODULE_DEVICE_TABLE(of, flexcan_of_match);
>  static const struct platform_device_id flexcan_id_table[] = {
>  	{
>  		.name = "flexcan-mcf5441x",
> -		.driver_data = (kernel_ulong_t)&fsl_mcf5441x_devtype_data,
>  	}, {
>  		/* sentinel */
> -	},
> +	}
>  };
>  MODULE_DEVICE_TABLE(platform, flexcan_id_table);
>
>
> base-commit: e7d700e14934e68f86338c5610cf2ae76798b663
> --
> 2.47.3
>
>

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature