Re: [PATCH v1] can: flexcan: Drop unused platform driver data

[Uwe Kleine-König (The Capable Hub)]

Hello Vincent,

On Thu, May 28, 2026 at 01:02:20PM +0200, Vincent Mailhol wrote:
> On 28/05/2026 at 11:45, Uwe Kleine-König (The Capable Hub) wrote:
> > No function in the flexcan driver ever accesses the .driver_data member
> > of its .id_table array as device_get_match_data() returns NULL for
> > non-of platform devices. So drop that unused assignment.
> > 
> > While touching that array, drop the trailing comma after the terminator
> > entry.
> > 
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> > ---
> > Hello,
> > 
> > I found this patch opportunity while working on a cleanup quest that has
> > unifying platform_device_id arrays as first step.
> > 
> > Best regards
> > Uwe
> >  drivers/net/can/flexcan/flexcan-core.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
> > index f5d22c61503f..1871def90fe3 100644
> > --- a/drivers/net/can/flexcan/flexcan-core.c
> > +++ b/drivers/net/can/flexcan/flexcan-core.c
> > @@ -2077,10 +2077,9 @@ MODULE_DEVICE_TABLE(of, flexcan_of_match);
> >  static const struct platform_device_id flexcan_id_table[] = {
> >  	{
> >  		.name = "flexcan-mcf5441x",
> > -		.driver_data = (kernel_ulong_t)&fsl_mcf5441x_devtype_data,
> 
> But now, fsl_mcf5441x_devtype_data becomes unused, right? Should this
> also be dropped?

Indeed. I would have expected that this results in a compiler warning,
but there isn't one for me and I expected that the struct is still
referenced in flexcan_of_match[] but obviously didn't check.

I'll wait with a v2 until the discussion in the neighbour thread in
reply to Marc's review ends.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature