Re: [PATCH v3 2/3] drm/bridge: display-connector: don't autoenable HPD IRQ

[Sebastian Reichel]

Hi,

On Thu, May 28, 2026 at 10:10:49AM +0300, Dmitry Baryshkov wrote:
> If HPD IRQ is enabled in the display_connector's probe, it can be
> triggered too early, before the DRM connector is completely setup. Use
> the enable_hpd / disable_hpd callbacks to control enablement of the HPD
> IRQ.
> 
> Fixes: 0c275c30176b ("drm/bridge: Add bridge driver for display connectors")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

-- Sebastian

>  drivers/gpu/drm/bridge/display-connector.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c
> index 16c0631adeb1..6bb1134f75c3 100644
> --- a/drivers/gpu/drm/bridge/display-connector.c
> +++ b/drivers/gpu/drm/bridge/display-connector.c
> @@ -87,6 +87,20 @@ display_connector_bridge_detect(struct drm_bridge *bridge, struct drm_connector
>  	return display_connector_detect(bridge);
>  }
>  
> +static void display_connector_hpd_enable(struct drm_bridge *bridge)
> +{
> +	struct display_connector *conn = to_display_connector(bridge);
> +
> +	enable_irq(conn->hpd_irq);
> +}
> +
> +static void display_connector_hpd_disable(struct drm_bridge *bridge)
> +{
> +	struct display_connector *conn = to_display_connector(bridge);
> +
> +	disable_irq(conn->hpd_irq);
> +}
> +
>  static const struct drm_edid *display_connector_edid_read(struct drm_bridge *bridge,
>  							  struct drm_connector *connector)
>  {
> @@ -178,6 +192,8 @@ static u32 *display_connector_get_input_bus_fmts(struct drm_bridge *bridge,
>  static const struct drm_bridge_funcs display_connector_bridge_funcs = {
>  	.attach = display_connector_attach,
>  	.detect = display_connector_bridge_detect,
> +	.hpd_enable = display_connector_hpd_enable,
> +	.hpd_disable = display_connector_hpd_disable,
>  	.edid_read = display_connector_edid_read,
>  	.atomic_get_output_bus_fmts = display_connector_get_output_bus_fmts,
>  	.atomic_get_input_bus_fmts = display_connector_get_input_bus_fmts,
> @@ -307,6 +323,7 @@ static int display_connector_probe(struct platform_device *pdev)
>  						NULL, display_connector_hpd_irq,
>  						IRQF_TRIGGER_RISING |
>  						IRQF_TRIGGER_FALLING |
> +						IRQF_NO_AUTOEN |
>  						IRQF_ONESHOT,
>  						"HPD", conn);
>  		if (ret) {
> 
> -- 
> 2.47.3
>

Attachment: signature.asc
Description: PGP signature