Re: [PATCH v3] staging: rtl8723bs: remove unnecessary parentheses

[Dan Carpenter]

On Mon, Jun 01, 2026 at 08:11:59PM +0200, Tomasz Unger wrote:
> Remove unnecessary parentheses to clear checkpatch.pl warnings
> 
> Example of fixed warnings:
> CHECK: Unnecessary parentheses around dvobj->cam_cache[id]
> CHECK: Unnecessary parentheses around 'val != 0xfe'

This changed in v3.

Btw, how were you even seeing this warning?  I disabled it.  Were
you working against an old tree?

> 
> Checkpatch warnings regarding line length above 100 columns on modified
> lines were also fixed

Please no, that's a separate fix.

> 
> V2->V3:
>   Reverted condition parentheses changes per Dan Carpenter's review:
>   staging rules deliberately silence this checkpatch warning
> 
> Changes in v3:
> - Reverted condition parentheses changes per Dan Carpenter's review
> - Link to v2: https://lore.kernel.org/all/20260531061022.573089-1-mavick4022@xxxxxxxxx/
> 

This stuff doesn't belong in the permanent git log.
There are still some changes which should be removed from the commit.

> Signed-off-by: Tomasz Unger <tomasz.unger@xxxxxxxx>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1: https://patch.msgid.link/20260527-staging-fix-1-v1-1-66ad880bcf76@xxxxxxxx

Those sorts of comments go here.

> 
> To: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-staging@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx

This stuff is fine since it is just discarded but it's also unnecessary.

regards,
dan carpenter