Re: [PATCH v5 0/2] Incorporate DRAM address in EDAC messages
From: Yazen Ghannam
Date: Mon Jun 01 2026 - 14:41:56 EST
On Wed, May 20, 2026 at 05:57:40PM -0700, Borislav Petkov wrote:
> On Mon, May 18, 2026 at 12:07:14PM -0400, Yazen Ghannam wrote:
> > Hi all,
> >
> > This revision addresses a comment from Sashiko in patch 2. The decision
> > to print the DRAM address will be independent of other decoding results.
>
> https://sashiko.dev/#/patchset/20260518160716.171578-1-yazen.ghannam%40amd.com
>
> Meh, gemini still finds stuff. Some of it is meh, the fake_inject thing
> probably needs fixing tho as I can see the concurrent f*ckup happening...
>
The fake_inject thing looks like it could happen with all EDAC modules.
But it seems unlikely because CONFIG_EDAC_DEBUG needs to be enabled to
enable fake_inject. Plus a user would need to use it at the same time as
a real DRAM ECC error occurs.
We could add a mutex to the mci struct and hold it during
edac_mc_handle_error().
What do you think?
Thanks,
Yazen