Re: [PATCH v2 3/7] rust: drm: Add RegistrationData to drm::Driver

From: Danilo Krummrich

Date: Thu Jun 04 2026 - 10:02:51 EST


On Thu Jun 4, 2026 at 1:29 AM CEST, Deborah Brouwer wrote:
> Hi Danilo, could we use separate data arguments in UnregisteredDevice
> vs in the Registration? Basically we want to use the UnregisteredDevice
> to initialize and boot the firmware which we then store as registration
> data.
>
> Could you have a look at this patch, it applies on top of this series:
> https://lore.kernel.org/rust-for-linux/20260603-use_tyr_reg_data-v1-1-97f64e951cf6@xxxxxxxxxxxxx/

They already are separate -- UnregisteredDevice::new() takes T::Data and
Registration::new() takes the registration data independently. Your patch
demonstrates this correctly.

I also replied to your patch with a few comments.

Thanks,
Danilo