Re: [PATCH net-next v1 1/6] r8169: add current_speed in private struct

From: Andrew Lunn

Date: Sat Jun 06 2026 - 05:58:43 EST


On Fri, Jun 05, 2026 at 06:39:00PM +0800, javen wrote:
> From: Javen Xu <javen_xu@xxxxxxxxxxxxxx>
>
> This patch adds current_speed in private strcut in order to decouple

struct.

> from phydev in the following patch supporting for phylink.
>
> Signed-off-by: Javen Xu <javen_xu@xxxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index ec4fc21fa21f..fdc8c84dd112 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -750,6 +750,7 @@ struct rtl8169_private {
> u32 irq_mask;
> int irq;
> struct clk *clk;
> + int current_speed;

Maybe just speed? The code would then be more consistent?


Andrew

---
pw-bot: cr