Re: [PATCH v4 4/4] clk: qcom: Add Global clock controller support on Qualcomm Shikra SoC

[Dmitry Baryshkov]

On Mon, Jun 08, 2026 at 10:16:39AM +0530, Imran Shaik wrote:
> 
> 
> On 06-06-2026 05:12 pm, Dmitry Baryshkov wrote:
> > On Fri, Jun 05, 2026 at 04:49:14PM +0530, Imran Shaik wrote:
> > > Add support for Global clock controller (GCC) on Qualcomm Shikra SoC.
> > > 
> > > Reviewed-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > 
> > I know that I've r-b'd the patch. But then I also compared GCC on Shikra
> > and Agatti. Is there a chance we can merge those?
> > 
> 
> The Shikra GCC has new addition of EMAC, PCIe, TSC, USB20, QUP subsystem
> clocks. Along with this, several Agatti clock/reset register offsets, as
> well as votable clock register offsets and enable BITs are updated on
> Shikra, and a few GPLL changes are also present.
> 
> I agree that few clocks duplication will be there, but it will be a clean
> and better approach to keep the separate driver and bindings for Shikra due
> to these new clock additions/changes.

Ok.

> 
> Thanks,
> Imran
> 
> > > Signed-off-by: Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx>
> > > ---
> > >   drivers/clk/qcom/Kconfig      |   10 +
> > >   drivers/clk/qcom/Makefile     |    1 +
> > >   drivers/clk/qcom/gcc-shikra.c | 4431 +++++++++++++++++++++++++++++++++++++++++
> > >   3 files changed, 4442 insertions(+)
> > > 
> > 
> 

-- 
With best wishes
Dmitry