Re: [PATCH] media: qcom: venus: add callback parameter names
From: Vishnu Reddy
Date: Mon Jun 08 2026 - 02:22:17 EST
On 6/4/2026 5:48 AM, Hungyu Lin wrote:
> Naming the callback parameters improves readability and resolves
> checkpatch warnings about unnamed function pointer arguments.
>
> No functional change intended.
>
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
> ---
> drivers/media/platform/qcom/venus/hfi_msgs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.c b/drivers/media/platform/qcom/venus/hfi_msgs.c
> index 47b99d5b5af7..5c2025c5acc7 100644
> --- a/drivers/media/platform/qcom/venus/hfi_msgs.c
> +++ b/drivers/media/platform/qcom/venus/hfi_msgs.c
> @@ -690,7 +690,7 @@ struct hfi_done_handler {
> u32 pkt;
> u32 pkt_sz;
> u32 pkt_sz2;
> - void (*done)(struct venus_core *, struct venus_inst *, void *);
> + void (*done)(struct venus_core *core, struct venus_inst *inst, void *packet);
> bool is_sys_pkt;
> };
>
Reviewed-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>