Re: [PATCH 3/7] iio: light: hid-sensor-als: use u32 instead of unsigned

[Joshua Crofts]

On Sat, 6 Jun 2026 at 14:19, Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx> wrote:
>
> From: Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>
>
> Prefer 'u32' instead of bare 'unsigned' variable to improve code
> clarity and consistency with kernel style.
>
> Signed-off-by: Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>
> ---
>  drivers/iio/light/hid-sensor-als.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
> index d72e260b8266..ae2fda8dc500 100644
> --- a/drivers/iio/light/hid-sensor-als.c
> +++ b/drivers/iio/light/hid-sensor-als.c
> @@ -241,7 +241,7 @@ static const struct iio_info als_info = {
>
>  /* Callback handler to send event after all samples are received and captured */
>  static int als_proc_event(struct hid_sensor_hub_device *hsdev,
> -                               unsigned usage_id,
> +                               u32 usage_id,
>                                 void *priv)

Code-wise fine, however looking at this function, usage_id is never
actually used,
though not sure whether removing it would break the ABI... up to you
to check it.

-- 
Kind regards

CJD