Re: [PATCH 00/15] Enable TDX Module Extensions and DICE-based TDX Quoting

[Xu Yilun]

On Sat, Jun 06, 2026 at 09:36:41PM -0700, Kishen Maloor wrote:
> On 5/21/26 8:41 PM, Xu Yilun wrote:
> > ...
> > This series has 2 distinct parts:
> > 
> >    Patches  1-4:  TDX Module Extensions enabling
> >    Patches  5-15: DICE-based TDX Quoting, primarily Peter's work.
> > 
> Perhaps the extensions enabling patches could be organized more simply as
> these three?
> 
> 1. Add TDX extensions metadata structure and accessor
> 2. Add TDH.EXT.MEM.ADD
> 3. Add TDH.EXT.INIT and wire extensions init into init_tdx_module()
> 
> This introduces the SEAMCALLs and lets the wiring land with the patch
> that completes the init flow, avoiding a separate "enable" patch.

Yes, several comments point to a same concern for patch organization - no
need a separate "enable" patch. Also a more sound justfication to me is,
the Extension will not actually been enabled until an add-on feature is
explicitly configured (See patch #15). So we could add steps in nature
order without worrying the incomplete flow breaks the kernel.

My reordering is:

 1. Add a placeholder for Extension initialization to hook into
    init_tdx_module(). Give a chance to explain the considerations of
    the enable-at-boot-up policy.

 2. Detect if Extension is required based on the metadata, if no, skip.
    So no side effect for following steps.

 3. Add TDH.EXT.MEM.ADD

 4. Add TDH.EXT.INIT
>