Re: [PATCH 1/2] clk: qcom: gdsc: add LEGACY_FOOTSWITCH support for MSM8x60

[Dmitry Baryshkov]

On Tue, Jun 02, 2026 at 07:08:37AM +0200, Herman van Hazendonk wrote:
> The MSM8x60 family (MSM8260, MSM8660, APQ8060) ships an older
> footswitch (FS / "GFS") block that pre-dates the GDSC programming
> model the existing driver was designed around. Adding GDSC entries
> for that family's MMCC power domains needs the driver to understand
> the legacy register layout:
> 

I think I've seen already this series. But this one doesn't have a cover
letter.

I'd kindly ask to do the following:
- Try using the b4 tool. It automates a lot of things for you, including
  some of the checks, cover letters, versioning, etc. You should be able
  to import your current series.

- Wait for a few more days, collect review comments and review-by's,
  then start sending the next iteration of the series. Don't rush, send
  them one by one, checking that the cover letters, versions are fine.

- Make sure that all changes are reflected in the bindings. If the
  binding is already in place and you are just sending the missing
  headers, mention it in the commit message.

- Comments are nice, but don't put too much into them. There is no need
  to explain everything again and again.

- Think from the reviewers point of view. Footswitch can go together
  with the mmcc patches. Or in one of the patches you were mentioning
  the apcs which doesn't (yet) exist for MSM8x60.

- Again, don't rush. You did a great job for a very nice hardware (I
  will even dig the APQ8060 out of my closet at some point), now let's
  get those merged.

-- 
With best wishes
Dmitry