Re: [PATCH net-next v2 02/14] net: phy: qcom: qca808x: Add regulator management

[Linus Walleij]

Hi Alex/Daniel,

thanks for your patch!

On Fri, Jun 5, 2026 at 3:00 AM Alex Elder <elder@xxxxxxxxxxxx> wrote:

> From: Daniel Thompson <daniel@xxxxxxxxxxxx>
>
> QCA8081 appears in embedded board designs paired with GPIO controlled
> regulators for its power rails. Add logic to allow these regulators to
> be turned on during a probe.
>
> In order to avoid the complexity of tracking state for suspend with and
> without WoL we take a tremendously simple "always-on" approach to
> regulator management, essentially relying on BMCR_PDOWN to conserve
> power when the phy device exists.
>
> Signed-off-by: Daniel Thompson <daniel@xxxxxxxxxxxx>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxxx>

(...)

> +#ifdef CONFIG_OF

Is this an extremely footprint-sensitive system?

Regulators provide small stubs if unused, I don't know if they
compile to zero bytes but this ifdeffery should normally not be
necessary, just unconditionally get_enable the regulators.

Yours,
Linus Walleij