Re: [PATCH] usb: typec: ps883x: Fix DP+USB3 configuration

[Konrad Dybcio]

On 6/1/26 3:55 PM, Stephan Gerhold wrote:
> Commit 6bebd9b77726 ("usb: typec: ps883x: Rework ps883x_set()") introduced
> two regressions:
> 
>  1. The CONN_STATUS_0_USB_3_1_CONNECTED bit is mistakenly written to the
>     wrong configuration register (cfg1 instead of cfg0). This breaks USB3
>     when using USB3+DP adapters.
> 
>  2. The switch-case fallthrough block is inverted: Currently,
>     TYPEC_DP_STATE_C (DP-only) inherits the USB3 configuration, while
>     TYPEC_DP_STATE_D (DP+USB3) is missing the necessary DP sink flags.
> 
> Fix these by writing the USB3 bit to the correct register and swapping the
> case statement order so both states get their correct bits assigned.

Oops.. sorry about this.. I only had a 4lndp display to test the DP
altmode path..

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad