Re: [PATCH 1/1] w1: ds2482: Use named initializers for arrays of i2c_device_data

[Krzysztof Kozlowski]

On 08/06/2026 11:43, Uwe Kleine-König (The Capable Hub) wrote:
> Hello,
> 
> On Thu, Jun 04, 2026 at 06:50:28PM +0200, Krzysztof Kozlowski wrote:
>> From: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
>>
>> While being less compact, using named initializers allows to more easily
>> see which members of the structs are assigned which value without having
>> to lookup the declaration of the struct. And it's also more robust
>> against changes to the struct definition.
>>
>> The mentioned robustness is relevant for a planned change to struct
>> i2c_device_id that replaces .driver_data by an anonymous union.
>>
>> This patch doesn't modify the compiled arrays, only their representation
>> in source form benefits. The former was confirmed with x86 and arm64
>> builds.
>>
>> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
>> Link: https://patch.msgid.link/20260518171456.872736-2-u.kleine-koenig@xxxxxxxxxxxx
>> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> 
> I wonder about this patch because it was included in next as
> 10cc9de3d4fc between next-20260526 and next-20260604 (inclusive) but
> isn't included any more in next-20260605.
> 
> I assume this mail is part of the submit path of w1 to mainline and
> Krzysztof dropped it from his tree to not create a conflict in next when
> Greg adds a slightly modified variant?

This was sent as patch, not pull-req, so to avoid duplicate patch
message from Mark.

> 
> If so, the expectation that this patch makes it into 7.2-rc1 is still
> justified, right?

Yes.

Best regards,
Krzysztof