Re: [PATCH v6] dmaengine: tegra210-adma: Add error logging on failure paths

[Jon Hunter]

On 12/05/2026 21:07, Frank Li wrote:
> On Tue, May 12, 2026 at 09:25:08AM +0000, Sheetal wrote:
> > Add dev_err/dev_err_probe logging across failure paths to improve
> > debuggability of DMA errors during runtime and probe.
> >
> > Use return dev_err_probe() pattern consistently in the probe function,
> > and dev_err in non-probe functions. Also convert existing dev_err calls
> > in probe to dev_err_probe for consistency.
> >
> > As part of the probe-path cleanup, use dmaenginem_async_device_register()
> > and devm_pm_runtime_enable(), and add tegra_adma_irq_dispose() for managed
> > IRQ mapping cleanup. These managed helpers remove the probe error unwind
> > labels while keeping the remove path minimal.
> >
> > Signed-off-by: Sheetal <sheetal@xxxxxxxxxx>
> > ---
>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>


Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Thanks!
Jon

--
nvpublic