Re: [PATCH] spi: cadence-xspi: Revert COMPILE_TEST support

[Mark Brown]

On Sat, Jun 06, 2026 at 03:26:04PM -0700, Nathan Chancellor wrote:
> Commit 0c5b5c40dc31 ("spi: cadence-xspi: Add COMPILE_TEST support")
> allows this driver to be built for 32-bit platforms, which causes a
> semantic conflict with commit 4954d4eca469 ("spi: cadence-xspi: Support
> 32bit and 64bit slave dma interface"), as readsq() and writesq() are
> only available when targeting 64-bit platforms:

>  config SPI_CADENCE_XSPI
>  	tristate "Cadence XSPI controller"
> -	depends on HAS_IOMEM || COMPILE_TEST
> -	depends on OF
> +	depends on OF && HAS_IOMEM && 64BIT
>  	depends on SPI_MEM

Why combine all these, they're not obviously related and HAS_IOMEM can
be turned off.

>  	help
>  	  Enable support for the Cadence XSPI Flash controller.
> diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c
> index e2bfb0c78b82..e1b337789fce 100644
> --- a/drivers/spi/spi-cadence-xspi.c
> +++ b/drivers/spi/spi-cadence-xspi.c
> @@ -22,10 +22,6 @@
>  #include <linux/bitrev.h>
>  #include <linux/util_macros.h>
>  
> -#ifndef CONFIG_64BIT
> -#include <linux/io-64-nonatomic-lo-hi.h>
> -#endif
> -
>  #define CDNS_XSPI_MAGIC_NUM_VALUE	0x6522
>  #define CDNS_XSPI_MAX_BANKS		8
>  #define CDNS_XSPI_NAME			"cadence-xspi"
> 
> ---
> base-commit: 4954d4eca469419339452cb5fea26dd0fc678c54
> change-id: 20260606-spi-cadence-xspi-revert-compile-testing-7919284daf5f
> 
> Best regards,
> --  
> Cheers,
> Nathan
>

Attachment: signature.asc
Description: PGP signature