Re: [PATCH 3/8] LoongArch: Add special section entry sizes for KLP support
From: George Guo
Date: Mon Jun 08 2026 - 07:04:06 EST
Hi WangYuli,
Thanks for the review -- all three points are addressed in v2:
https://lore.kernel.org/all/20260608100406.322598-1-dongtai.guo@xxxxxxxxx/
> Have you actually tested your changes with LLVM?
Yes, now confirmed: the affected files build cleanly with
'make LLVM=1' (clang). You were right that this had not been properly
exercised before -- the writable special sections were the real problem.
> BTW, "awM" is dangerous, pls see how did x86 do.
Fixed. __bug_table and __jump_table are writable, and SHF_MERGE cannot be
combined with SHF_WRITE (Clang rejects it). v2 drops "awM"/entsize on
those two and marks each entry with ANNOTATE_DATA_SPECIAL instead, just
as x86 and arm64 do; SHF_MERGE is kept only for the read-only
.altinstructions/__ex_table.
> And head.S doesn't need to include asm-offsets.h, it seems
> stackframe.h has included it.
Correct, removed -- head.S already pulls it in via <asm/stackframe.h>.
Thanks,
George