Re: [PATCH v2 2/2] spi: ma35d1-qspi: Add Nuvoton MA35D1 QSPI controller support

[Mark Brown]

On Mon, Jun 08, 2026 at 10:50:09AM +0800, Chi-Wen Weng wrote:
> Add SPI controller driver support for the Nuvoton MA35D1 Quad SPI
> controller.

> +static void nuvoton_qspi_mem_set_cs(struct spi_device *spi, bool enable)
> +{
> +	struct nuvoton_qspi *qspi = spi_controller_get_devdata(spi->controller);
> +	bool assert = enable;
> +
> +	if (spi->mode & SPI_CS_HIGH)
> +		assert = !assert;

Hrm, we should have the core deal with this.  Separate issue though.

> +	ctlr->num_chipselect = NUVOTON_QSPI_DEFAULT_NUM_CS;
> +	ctlr->mem_ops = &nuvoton_qspi_mem_ops;

We don't specify mem_caps, I'm vaugely surprised nothing trips over that
when testing.

Attachment: signature.asc
Description: PGP signature