Re: [PATCH 04/37] drm/display: bridge-connector: store the drm_device pointer

From: Maxime Ripard

Date: Mon Jun 08 2026 - 07:34:37 EST


Hi,

On Tue, May 19, 2026 at 12:37:21PM +0200, Luca Ceresoli wrote:
> Currently the struct drm_device pointer is only needed during the initial
> drm_bridge_connector_init() and in drm_bridge_connector_handle_hpd() which
> gets it from the struct drm_connector.
>
> This will be insufficient when introducing bridge hotplugging, because:
>
> * some of the actions in drm_bridge_connector_init() will have to be
> performed later on, when a bridge is hot(un)plugged
> * the connector will be removed and re-added based on hotplug events,
> so the drm_connector might just not exist or its content be cleared
>
> Store the drm_device pointer in struct drm_bridge_connector for any later
> needs. Also convert drm_bridge_connector_handle_hpd() to use the newly
> stored value.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

This is already accessible as drm_connector->dev and drm_bridge->dev. I
think it would be great to list why this is different, and how it is
different (ie, when it's set, unset).

Maxime

Attachment: signature.asc
Description: PGP signature