Re: [PATCH net-next v5 1/4] dpll: add DPLL_PIN_TYPE_INT_NCO pin type

[Vadim Fedorenko]

On 04/06/2026 17:42, Ivan Vecera wrote:
> On 6/4/26 5:16 PM, Jakub Kicinski wrote:
> > On Thu, 4 Jun 2026 17:01:36 +0200 Ivan Vecera wrote:
> > > > Purely going on intuition here but feels like NCO should be a mode
> > > > (enum dpll_mode) rather than one of the input pins?
> > > >
> > > > More acks here would be great, Vadim, Arkadiusz, Grzegorz... ?
> > >
> > > I had a long discussion with Jiri about this and we agreed finally
> > > that dpll_mode represents a reference (input pin) selection strategy
> > > mode and not a DPLL device running mode.
> >
> > Long discussion? I see 2 emails ;) Let's hear from others.
> > (thanks for the link BTW, _if_ there's a v6 please put it in the cover
> > letter)
>
> I called him... he explained me 'why?' in detail.
> I also appreciate others' opinion.

Well, NCO mode means manual operation of frequency tuning. Does it mean
that different tunings may be applied to different out pins of DPLL
device? My assumption that it's not possible, and in this case NCO is
property/mode of DPLL device rather than single pin.

@Jiri could you please share your detailed explanation on "why"?