Re: [RFC PATCH 06/18] drm/panthor: Derive MMU AS register addresses from base and stride

[Boris Brezillon]

On Thu, 28 May 2026 16:05:34 +0100
Karunika Choo <karunika.choo@xxxxxxx> wrote:

> diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
> index 48127313332f..9a64f977d28c 100644
> --- a/drivers/gpu/drm/panthor/panthor_mmu.c
> +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
> @@ -36,6 +36,7 @@
>  #include "panthor_gpu.h"
>  #include "panthor_gpu_regs.h"
>  #include "panthor_heap.h"
> +#include "panthor_hw.h"
>  #include "panthor_mmu.h"
>  #include "panthor_mmu_regs.h"
>  #include "panthor_sched.h"
> @@ -57,7 +58,7 @@ struct panthor_as_slot {
>   */
>  struct panthor_mmu {
>  	/** @iomem: CPU mapping of MMU_AS_CONTROL iomem region */
> -	void __iomem *iomem;
> +	void __iomem *iomem[MAX_AS_SLOTS];

Can we move the iomem field to panthor_as_slot?

>  
>  	/** @irq: The MMU irq. */
>  	struct panthor_irq irq;