RE: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 08 June 2026 13:23
> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
> 
> On 08/06/2026 14:15, Biju Das wrote:
> > Hi Krzysztof Kozlowski,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >> Sent: 08 June 2026 13:12
> >> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert
> >> renesas,r9a08g046-lvds-cmn
> >>
> >> On 08/06/2026 13:59, Biju Das wrote:
> >>> Hi Krzysztof Kozlowski,
> >>>
> >>>> -----Original Message-----
> >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> >>>> Sent: 08 June 2026 12:55
> >>>> Subject: [PATCH] dt-bindings: mfd: syscon: Revert
> >>>> renesas,r9a08g046-lvds-cmn
> >>>>
> >>>> Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the
> >>>> LVDS_CMN syscon for the RZ/G3L") because it is completely not
> >>>> matching reality and clearly incorrect in respect of renesas,r9a08g046- lvds-cmn.
> >>>>
> >>>> It wasn't ever build-tested by author on their DTS, either.
> >>>
> >>> You are wrong here.
> >>>
> >>> It is tested with below DTS,
> >>
> >> Sure, I believe you. Binding is still obviously wrong and does not match the DTS at all.
> >
> > You are not actually pointing to the mistake in the bindings. It is reviewed by Conor.
> 
> I described it very clear in the part of the msg YOU REMOVED.
> 
> Does not matter if it was reviewed by Conor. The patch looked correct for our eyes when looking ALONE
> at this patch, I also would not spot the issue. You as the author have the complete picture and you
> should see that it is completely bogus combination of compatibles.

I missed adding r9a08g046-lvds-cmn in the top block, which skipped the DT binding checks.

Now I getting the below warnings, after adding the compatible to select block.

/home/biju/share/linux-work/linux/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc.dtb: lvds-cmn@108a0000 (renesas,r9a08g046-lvds-cmn): compatible: 'oneOf' conditional failed, one must be fixed:
	['renesas,r9a08g046-lvds-cmn', 'simple-mfd', 'syscon'] is too long

For your patch,

Acked-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

So going forward, I will create [1] with the below compatible and properties.

[1] Documentation/devicetree/bindings/mfd/renesas,r9a08g046-lvds-cmn.yaml

  compatible:
    items:
      - enum:
          - renesas,r9a08g046-lvds-cmn
      - const: simple-mfd
      - const: syscon

  reg:
    maxItems: 1

  "#address-cells": true

  "#size-cells": true

  ranges: true

patternProperties:
  "^lvds@[0-9a-f]+$":
    $ref: /schemas/display/bridge/renesas,r9a08g046-lvds.yaml#

required:
  - compatible
  - reg


Cheers,
Biju